Bug found, exception when using Nette\Database\Table\Selection::fetchPairs with null parameters

@kasi

Hi,

I do not understand the problem in full, but I´m standardly using Selection::fetchPairs() for getting data for form input select, where are data in form of array required. So I typically use it like this:

   $selectItems = $this->database->table('tableName')->where(...)->order(...)->fetchPairs('id', 'title');

   .....

   $form->addSelect('field', 'Caption', $selectItems);

This works without any problems.

The data $selectItems look like this:

[
   '2' => 'green',   //  id => title
   '6' => 'yellow',
   .....
]

But you may be use the method fetchPairs() in other way, send eventually more code samples in case you will not solve the problem ;).

m.brecher wrote:

@kasi

Hi,

I do not understand the problem in full, but I´m standardly using Selection::fetchPairs() for getting data for form input select, where are data in form of array required. So I typically use it like this:

   $selectItems = $this->database->table('tableName')->where(...)->order(...)->fetchPairs('id', 'title');

   .....

   $form->addSelect('field', 'Caption', $selectItems);

This works without any problems.

The data $selectItems look like this:

[
   '2' => 'green',   //  id => title
   '6' => 'yellow',
   .....
]

But you may be use the method fetchPairs() in other way, send eventually more code samples in case you will not solve the problem ;).

So for example if you will have table

id	username	password
1	user1	hash1
2	user2	hash2

and i want to fetch normal indexed array, i need to write something like this

public function arrayFrom(Nette\Database\Table\Selection $selection):array {
        $rows = [];
        while ($row = $selection->fetch()) {
            $rows[] = iterator_to_array($row->getIterator());
        }
        return $rows;
    }

which will produce following array ->

[
	0 => [
		'id' => 1,
		'username' => user1,
		'password' => hash1,
	],
	1 => [
		'id' => 2,
		'username' => user2,
		'password' => hash2,
	],
]

And i think it should work like this if you dont push null parameters to

Nette\Database\Table\Selection::fetchPairs(string|int|null $key = null, string|int|null $value = null)

because when you will write something like this:

$rows = $this->database->table('user')->select('id, username')->fetchAll();
$rowsOnlyData = [
    1 => [
        'data' => [
            'id' => 1,
            'username' => 'user1'
        ]
    ],
    2 => [
        'data' => [
            'id' => 2,
            'username' => 'user2'
        ]
    ]
];
$result = Nette\Database\Helpers::toPairs($rowsOnlyData);

then the $result will be:

[
	0 => [
		'id' => 1,
		'username' => 'user1',
	],
	1 => [
		'id' => 2,
		'username' => 'user2',
	],
]

In the other words, if function

 Nette\Database\Helpers::toPairs(array $rows, $key = null, $value = null)

does not get parameters $key and $value it will take it from array_keys.

I think, it is confusing. Function

Nette\Database\Table\Selection::fetchPairs(string|int|null $key = null, string|int|null $value = null)

should not has null values, or may be customized in working way.