NEON remove php settings for forward compatibility

4 years ago

h4kuna
Backer | 717
+
0
-

Hi,
we have production machine on php 5.4 and now i test php 5.6 where php settings are deprecated. For example:

php:
    iconv.internal_encoding: UTF-8
    mbstring.internal_encoding: UTF-8

I haven't choice how this setting remove via my config.local.neon. If I don't comment it than tracy execute.

Is good idea implemet behavior whose setup NULL than remove this option?
For example my config.local.neon:

php:
    iconv.internal_encoding: NULL # This not write to SystemContainer.

Is it another option?

4 years ago

Michal Vyšinský
Member | 614
+
0
-

Hi,
if you need to run on php 5.4 machine and you really need those configuration why not add it to php.ini? But I would upgrade to php 5.6 everywhere. :)

4 years ago

h4kuna
Backer | 717
+
0
-

Set to php.ini is good idea for one machine, but for more… Here it can happen than anybody forget for this. In this momemnt only I have php 5.6 nobody from team.

Upgrade is in plan.

Yes this feature is for a few month and a few projects, therefore is discussion.

4 years ago

Jan Tvrdík
Nette guru | 2563
+
+1
-

@h4kuna Send PR, not calling ini_set for NULL values seems reasonable. Or I can do it for you.

4 years ago

h4kuna
Backer | 717
+
0
-

@JanTvrdík I will look at this weekend and write you what is result. I don't know how is it easy or hard.

4 years ago

Jan Tvrdík
Nette guru | 2563
+
0
-

Its 3 lines of code.

4 years ago

h4kuna
Backer | 717
+
0
-