Nette 2.3.0 beta for testing

removed case insensivity for presenter and action names

Well, I would postpone this to 3.0, since there is not any tool, which would safely check all my links, that they are valid. However, such tool could make the migration easier and BC break defensible for 2.3.

@hrach I added this, it throws warning when link or router has wrong case and should maintain BC.

The generated temp/cache/Nette.Configurator/Container_xxx.php ends with public function create():

<?php
	Nette\Utils\Html::$xhtml = FALSE;;
	return $service;
?>

Why doubling ;; on the xhtml setup line?

I'm little bit afraid of change with moving presenters into container.

We have overloaded presenters loading mechanism. It depends on particular presenter file path and file_exists() calls, so it cannot be used with the presenters in container I think. Robot loader currently also skip folders with presenters.

Is this scenario usable in 2.3 same way it was in 2.2 – just use own PresenterFactory?

@blindAlley it should work with your own loader, but please test it. If it will not work, open new thread here on forum.

One week later and beta2 is here.

• Application: reverted that action name can begin with number
• PresenterFactory: fixed compatibility with case mismatched presenter names
• Bootstrap::setDebugMode – argument must be string|array|bool
• DI: removed dependency on nette/reflection
• DI: magic methods replaced with native ones (is 3× faster)
• DI: implemented escaping of ‘@’ at the beginning of string
• DI\Container::findByType() returns all services, including non-autowired (BC break!!)
• Forms: reverted that addText, addPassword, addTextArea: parameter $cols is deprecated
• Forms: added deprecation warning to deprecated addFilter()
• Forms: added RadioList::$generateId that enables generating of ID
• PhpGenerator: magic methods replaced with native ones
• RobotLoaders: warns on case mismatch on class name
• … and some bugs fixed

All components are finished. Only nette/application is in beta phase, because nette/application#4 is not merged yet.

I'll probably will close all of them and create new PR.

If you use Nette\Database like me, check this. After update to Nette 2.3 beta I got this message:

SQLSTATE[42000]: Syntax error or access violation: 1253 COLLATION 'utf8_general_ci' is not valid for CHARACTER SET 'utf8mb4'

I looked into changelog and I saw this point:

• MySqlDriver: uses utf8mb4 encoding for MySQL >= 5.5.3

So after a hour of searching, I added options: [charset: utf8] and problem was resolved.

database:
	dsn: 'mysql:host=localhost;dbname=database'
	user: username
	password: password
	options: [charset: utf8]

Is it about this patch and I absolutely don't understand the benefits of the new behaviour.

Last edited by o5 (2015-02-19 09:15)

David Grudl wrote:

Are you doing with database something special?

I think not.

SELECT *
FROM `table`
WHERE (`column` LIKE 'ro%' COLLATE `utf8_general_ci`)
LIMIT 10

@JanTvrdík Yes, I read twitter :)

Why is deprecated support for Nette\Templating in Mail?

@enumag Thanks;)

If I installed new version I get these errors:

problem in latte with class

Latte\CompileException
It is not possible to combine class with n:class in`

from

<div class="row" n:class="$input->required ? required">

to

<div n:class="$input->required ? required, row">

fixed

sending email from template

User Deprecated
Support for Nette\Templating is deprecated

from

	$mail->addTo($email)
	->setHtmlBody($template);

to

	$mail->addTo($email)
	->setHtmlBody((string)$template);

fixed

when the email template use <img src=

Nette\FileNotFoundException
Unable to read file ‘/image/logo.png’.

from

<img src="image/logo.png"  />

	$mail->->setHtmlBody($template);

to

$mail->setHtmlBody((string)$template, dirname($template->getFile()));

fixed (thanx @enumag)

Last edited by chemix (2015-02-16 22:18)

@chemix I changed it a little bit, is it better? https://github.com/…fe9342eb35f9. The (string) $template is not required now. But setting i.e. $mail->subject inside template will not work unless you manually add $mail parameter to template.

One older app updated without bigger problems. One silent issue is case-sensitivity of a route mask.

# didn't match lowercased URL
'<lang cs|en>/<presenter Private|Settings|Search|Admin>/<action>[/<id>]'

# fixed mask is matching now
'<lang cs|en>/<presenter private|settings|search|admin>/<action>[/<id>]'

It is not issue for me, just note.

Hi. I have very strange problem with two projects on Nette 2.3. If I deleted the cache then I launched tests using Nette\Tester and then I opened the project in the browser (or vice versa – delete cache, open in the browser and run the tests), I got something like Fatal Error: Class ‘Template6204ecb8aa28def219f530ae783277ec’ not found. To be honest, I have no idea what's going on and I am not sure if it's bug or it's problem in my code (because nobody noticed). This behavior is only with new verion of Nette. I know, it's not very verbose error – do you need a bluescreen? Any idea?

@mrtnzlml in which file and on which line?

@Eda fixed

And template file exists? Contains a class?

David Grudl wrote:

And template file exists? Contains a class?

No, it doesn't exist. This name occurs only in the robotloader cache file. Another weird thing. There are *.php and *.php.lock files with the same name (not related to the tests). I didn't notice this behavior in previous versions. It doesn't look good.

Maybe the problem is related to the fact, that I am trying to run templates in tests (like this) I guess. It's because It doesn't work when the cache is generated using tests. It works only if the cache is generated in the same environment a want to access later without troubles. Is that possible?

I just noticed that there are mentioned two classes form the diferend project (if I run the tests first) at the end of the robotloader file. I should look how does it work actually. How it's even possible, that it knows about this classes? And again – it occurs only in robotloader. Same as the Template* name…

David Grudl wrote:

@mrtnzlml RobotLoader is indexing your temp dir? Yes, it can break Latte.

No. Only app folder. Nothing unusual.

David Grudl wrote:

@mrtnzlml Do you run tests in multiple threads with the same temp dir? Is temp dir cleaned by purge()?

I am trying to figure this out in one project I started about month ago so the test bootstrap is very similar to the sandbox one. It means the same temp dir for every test (i default 8 thread mode) without purge. Obviously it works if I am using different temp dir for tests and different for the classic way. Is this the right solution? Should I use more temp directories? And if so, should it be also in the sandbox?

David Grudl wrote:

@mrtnzlml Multithread without purge seems fine. Can you try to apply this commit? Or send me email with minimal failing code?

This revert doesn't solve the issue. It is the reason of the *.php.lock files in latte cache, but it's not the reason of my fatal error.

I figured out what's the reason of this fatal error and it's definitely in my code, but I think that this behavior is quite brutal and as you will see it doesn't look like fatal error in my code. I just downloaded nette\sandbox with stability dev and created this simple method in default test case:

function testRenderDefault()
{
	$presenterFactory = $this->container->getByType('Nette\Application\IPresenterFactory');
	$presenter = $presenterFactory->createPresenter('Homepage');
	$presenter->autoCanonicalize = FALSE;

	$request = new Nette\Application\Request('Homepage', 'GET', array('action' => 'default'));
	$response = $presenter->run($request);

	Tester\Assert::true($response instanceof Nette\Application\Responses\TextResponse);
	Tester\Assert::true($response->getSource() instanceof Nette\Application\UI\ITemplate);

	$html = (string) $response->getSource(); //ERR
	// $html = $response->getSource(); //OK

	return $response;
}

Result: Fatal Error: Class ‘Templated9516166f211b79e2d4660dd2994d776’ not found

So the reason is string typecast. I read something with string casting before but it's only related to the email templates, right? I can send you the sandbox if you want to. I don't know why is that and how to fix it (or if it should be fixed).

Win 8.1, PHP 5.5.15

If I remove the string typecast, it works OK.

Fixed. World is saved!