{snippet} a jeho druhý parametr

Ahoj, ve třídě SnippetHelper mám návrh na vylepšení. 3. volitelný parametr by nadále akceptoval string, ale akceptoval by i třídu Html. Implementováno to vypadá takto:

/**
 * Control snippet template helper.
 *
 * @author     David Grudl
 * @copyright  Copyright (c) 2004, 2009 David Grudl
 * @package    Nette\Templates
 */
class SnippetHelper extends /*Nette\*/Object
{
	/** @var bool */
	public static $outputAllowed = TRUE;

	/** @var string */
	private $id;

	/** @var Html */
	private $tag;

	/** @var ArrayObject */
	private $payload;

	/** @var int */
	private $level;



	/**
	 * Starts conditional snippet rendering. Returns SnippetHelper object if snippet was started.
	 * @param  Control      control
	 * @param  string       snippet name
	 * @param  string|Html  start element
	 * @return SnippetHelper
	 */
	public static function create(/*Nette\Application\*/Control $control, $name = NULL, $tag = 'div')
	{
		if (self::$outputAllowed) { // rendering flow or non-AJAX request
			$obj = new self;
                        if(is_string($tag)){
                            $obj->tag = HTML::el(trim($tag, '<>'));
                        }elseif($tag instanceof Html){
                            $obj->tag = $tag;
                        }else throw new InvalidArgumentException("Parameter 'tag' must be string or instace of Html.");
                        if ($obj->tag){
                            $obj->tag->id = $control->getSnippetId($name);
                            echo $obj->tag->startTag();
                        }
			return $obj; // or string?

		} elseif ($control->isControlInvalid($name)) { // start snippet buffering
			$obj = new self;
			$obj->id = $control->getSnippetId($name);
			$obj->payload = $control->getPresenter()->getPayload();
			ob_start();
			$obj->level = ob_get_level();
			self::$outputAllowed = TRUE;
			return $obj;

		} else {
			return FALSE;
		}
	}



	/**
	 * Finishes and saves the snippet.
	 * @return void
	 */
	public function finish()
	{
		if ($this->tag !== NULL) { // rendering flow or non-AJAX request
			if ($this->tag) echo $this->tag->endTag();

		} else {  // finish snippet buffering
			if ($this->level !== ob_get_level()) {
				throw new /*\*/InvalidStateException("Snippet '$this->id' cannot be ended here.");
			}
			$this->payload->snippets[$this->id] = ob_get_clean();
			self::$outputAllowed = FALSE;
		}
	}

}

Změny:

– PHPDoc
 – v metodě finish(): echo $this->tag->endTag();
 – v metodě create():

if(is_string($tag)){
    $obj->tag = HTML::el(trim($tag, '<>'));
}elseif($tag instanceof Html){
    $obj->tag = $tag;
}else throw new InvalidArgumentException("Parameter 'tag' must be string or instace of Html.");
if ($obj->tag){
    $obj->tag->id = $control->getSnippetId($name);
    echo $obj->tag->startTag();
}

Použití

Když potřebuji tagu snippetu přidat nějaký atribut.

EDIT: Myslíš, že by se něco takového dalo dát do distribuce? Připravuji komponentu TabControl (tabování bez JS nebo s jQuery UI) a tam by se mi to docela dosti hodilo.

Editoval honzakuchar (2. 8. 2009 12:05)