Form as component, its handler and possible BC break in 2.3.0?

Hey, I am using forms wrapped by components as components and after upgrading from 2.2 to 2.3 i am encountering following error: Component '' is not attached to ‘Nette\Application\UI\Presenter’ in presenter, when trying to set callback for onSuccess event.

Just to mention, i am using Kdyby\Autowired, not using this does not affect this issue

	// XyPresenter.php
	protected function createComponentXyForm(IControlFactory $factory)
	{
		$control = $factory->create();
		$control["form"]->onSuccess[] = function($form) { // On this line error is occuring
			$this->redirect("default");
		};
		return $control;
	}

	// Control.php (created by IControlFactory)
	protected function createComponentForm(FormFactory $factory)
	{
		return $factory->create($this->entity);
	}

I was able to fix this error adding Nette event to Control and passing form callback to it, instead of directly to the form, like this:

	// XyPresenter.php
	protected function createComponentXyForm(IControlFactory $factory)
	{
		$control = $factory->create();
		$control->onFormSuccess[] = function($form) {
			$this->redirect("default");
		};
		return $control;
	}

	// Control.php
	public $onFormSuccess = [];

	protected function createComponentForm(FormFactory $factory)
	{
		$form = $factory->create($this->entity);
		$form->onSuccess[] = function($form) {
			$this->onFormSuccess($form);
		};
		return $form;
	}

I believe that my fix for the problem is much cleaner solution, but is not this unmentioned BC break or why code, which worked on previous version is not working anymore?

Last edited by Lexi (2015-03-13 11:56)